Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go 1.21 and fix lint issues #490

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Update go 1.21 and fix lint issues #490

merged 3 commits into from
Sep 29, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Sep 21, 2023 •
edited
Loading

What this PR does / why we need it

  • Updated github workflows to use go 1.21
  • Updated root and test go.mod to use go v1.21
  • Update tools like linters to latest
  • Fix lint issues
  • Removed deprecated linters deadcode, varcheck, structcheck, unparam

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

  • Build the Tanzu CLI
  • Perform basic lifecycle ops
  • Unit tests, Lint checks

Release note

Tanzu CLI is updated to latest go v1.21

Additional information

Special notes for your reviewer

@mpanchajanya mpanchajanya marked this pull request as ready for review September 21, 2023 15:17
@mpanchajanya mpanchajanya requested a review from a team as a code owner September 21, 2023 15:17
@mpanchajanya mpanchajanya mentioned this pull request Sep 22, 2023
Closed
@mpanchajanya mpanchajanya force-pushed the topic/go-update_1_21 branch 5 times, most recently from 8d93506 to 429eb1b Compare September 26, 2023 02:35
anujc25
anujc25 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the changes to use go v1.21
Let's file an issue to address the linter that needs to be enabled after addressing the errors.

@mpanchajanya
Copy link
Contributor Author

mpanchajanya commented Sep 29, 2023 •
edited
Loading

LGTM. Thanks for all the changes to use go v1.21 Let's file an issue to address the linter that needs to be enabled after addressing the errors.

Created JIRA to fix the disabled lint issues

@mpanchajanya mpanchajanya merged commit 44e91db into vmware-tanzu:main Sep 29, 2023
4 checks passed
@marckhouzam marckhouzam added this to the 1.1.0 milestone Oct 20, 2023
@mpanchajanya mpanchajanya deleted the topic/go-update_1_21 branch November 16, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anujc25 anujc25 anujc25 approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mpanchajanya @anujc25 @marckhouzam @vmwclabot